Updated tests with new error IDs #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhibaruah
reviewed
May 2, 2025
| import matlab.unittest.fixtures.WorkingFolderFixture; | ||
| testcase.applyFixture(WorkingFolderFixture); | ||
|
|
||
| % Add the existing files to the current folder | ||
| copyfile(fullfile(currDir,'dataFiles'),pwd); |
There was a problem hiding this comment.
Where does this get get cleaned?
There was a problem hiding this comment.
The WorkingFolderFixture automatically takes care of it. See https://www.mathworks.com/help/matlab/ref/matlab.unittest.fixtures.workingfolderfixture-class.html#bu2oxjj-2
abhibaruah
reviewed
May 2, 2025
| 'Compression',comp),testcase.PyException); | ||
| 'Compression',comp),errID); | ||
|
|
||
| comp = 'zlib'; |
There was a problem hiding this comment.
Can you add a comment here for this test?
abhibaruah
reviewed
May 2, 2025
| zarrwrite(testcase.ArrPathWrite,expData); | ||
|
|
||
| actData = zarrread(testcase.ArrPathWrite); | ||
| testcase.verifyEqual(actData,expData,'Failed to verify data.'); |
There was a problem hiding this comment.
Should we also test if the correct compression was used (using zarrinfo)?
abhibaruah
reviewed
May 2, 2025
| zarrwrite(testcase.ArrPathWrite,expData); | ||
|
|
||
| actData = zarrread(testcase.ArrPathWrite); | ||
| testcase.verifyEqual(actData,expData,'Failed to verify data.'); |
There was a problem hiding this comment.
Should we also test if the correct compression was used (using zarrinfo)?
|
Fix for #64 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated tests with new error IDs